Conversation
asyncapi-bot
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
❌ Deploy Preview for asyncapi-website failed.
|
📝 WalkthroughWalkthroughThree configuration files were updated with metadata modifications: catalog tag names swapped in all-tags.json, extensive tool entries reorganized and reclassified in tools-automated.json with category and ownership adjustments, and repository and documentation URLs corrected in tools.json. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5159 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@config/tools-automated.json`:
- Around line 118-136: The "language" value for the JSON entry titled
"nestjs-asyncapi" is spelled "Typescript" and must be normalized to "TypeScript"
to match the rest of the file; locate the object with "title": "nestjs-asyncapi"
and update its "language" property to "TypeScript" so case-sensitive consumers
and filters behave consistently.
- Around line 594-615: The "Specmatic" entry's filters.technology contains
"maven" in lowercase which is inconsistent with the rest of the catalog; update
the value in the Specmatic object (the "title": "Specmatic") by changing the
"maven" string to "Maven", and make the same change for the other CLIs entry
that uses "maven" so all filters.technology values use the capitalized "Maven"
consistently.
| { | ||
| "title": "nestjs-asyncapi", | ||
| "description": "Utilize decorators to generate AsyncAPI document utilizing DTOs (similar to @nestjs/swagger) and a web UI.", | ||
| "links": { | ||
| "repoUrl": "https://github.com/flamewow/nestjs-asyncapi" | ||
| }, | ||
| "filters": { | ||
| "language": "Typescript", | ||
| "technology": [ | ||
| "Node.js", | ||
| "NestJS" | ||
| ], | ||
| "categories": [ | ||
| "code-first" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| } | ||
| }, |
There was a problem hiding this comment.
Inconsistent casing: "Typescript" vs "TypeScript" on line 125.
The nestjs-asyncapi entry uses "language": "Typescript" (lowercase 's') while other entries in this file consistently use "TypeScript" (e.g., line 40, 235, 509). This could cause filtering/matching issues if consumers do case-sensitive comparisons.
Proposed fix
"filters": {
- "language": "Typescript",
+ "language": "TypeScript",
"technology": [📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "title": "nestjs-asyncapi", | |
| "description": "Utilize decorators to generate AsyncAPI document utilizing DTOs (similar to @nestjs/swagger) and a web UI.", | |
| "links": { | |
| "repoUrl": "https://github.com/flamewow/nestjs-asyncapi" | |
| }, | |
| "filters": { | |
| "language": "Typescript", | |
| "technology": [ | |
| "Node.js", | |
| "NestJS" | |
| ], | |
| "categories": [ | |
| "code-first" | |
| ], | |
| "hasCommercial": false, | |
| "isAsyncAPIOwner": false | |
| } | |
| }, | |
| { | |
| "title": "nestjs-asyncapi", | |
| "description": "Utilize decorators to generate AsyncAPI document utilizing DTOs (similar to `@nestjs/swagger`) and a web UI.", | |
| "links": { | |
| "repoUrl": "https://github.com/flamewow/nestjs-asyncapi" | |
| }, | |
| "filters": { | |
| "language": "TypeScript", | |
| "technology": [ | |
| "Node.js", | |
| "NestJS" | |
| ], | |
| "categories": [ | |
| "code-first" | |
| ], | |
| "hasCommercial": false, | |
| "isAsyncAPIOwner": false | |
| } | |
| }, |
🤖 Prompt for AI Agents
In `@config/tools-automated.json` around lines 118 - 136, The "language" value for
the JSON entry titled "nestjs-asyncapi" is spelled "Typescript" and must be
normalized to "TypeScript" to match the rest of the file; locate the object with
"title": "nestjs-asyncapi" and update its "language" property to "TypeScript" so
case-sensitive consumers and filters behave consistently.
| { | ||
| "title": "Specmatic", | ||
| "description": "Transform your API Specs into Executable Contracts with #NoCode in Seconds. Experience the power of Contract-Driven Development to confidently develop and independently deploy your Microservices and Microfrontends faster", | ||
| "links": { | ||
| "websiteUrl": "https://specmatic.io", | ||
| "docsUrl": "https://specmatic.io/documentation/", | ||
| "repoUrl": "https://github.com/specmatic/specmatic" | ||
| }, | ||
| "filters": { | ||
| "language": "kotlin", | ||
| "technology": [ | ||
| "Docker", | ||
| "maven" | ||
| ], | ||
| "categories": [ | ||
| "mocking-and-testing", | ||
| "CLIs" | ||
| ], | ||
| "hasCommercial": true, | ||
| "isAsyncAPIOwner": false | ||
| } | ||
| }, |
There was a problem hiding this comment.
Inconsistent technology tag casing: "maven" (lowercase) on line 606.
The Specmatic entry uses "maven" (lowercase) while other entries consistently use "Maven" with a capital M (e.g., lines 211, 627, 832). Same issue appears in the CLIs section at line 792. This could cause filtering mismatches.
Proposed fix
"technology": [
"Docker",
- "maven"
+ "Maven"
],Apply in both locations (line 606 and line 792).
🤖 Prompt for AI Agents
In `@config/tools-automated.json` around lines 594 - 615, The "Specmatic" entry's
filters.technology contains "maven" in lowercase which is inconsistent with the
rest of the catalog; update the value in the Specmatic object (the "title":
"Specmatic") by changing the "maven" string to "Maven", and make the same change
for the other CLIs entry that uses "maven" so all filters.technology values use
the capitalized "Maven" consistently.
|
2 participants
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit